Skip to content

Add matching2 option handling#15601

Merged
Megamouse merged 1 commit into
RPCS3:masterfrom
RipleyTom:add_match2_option
May 16, 2024
Merged

Add matching2 option handling#15601
Megamouse merged 1 commit into
RPCS3:masterfrom
RipleyTom:add_match2_option

Conversation

@RipleyTom
Copy link
Copy Markdown
Contributor

Matching2 contexts have an option setting that had gone unnoticed until now, it can specify if the game is interested in online name and avatar url data.

Until know we ignored that setting and gave the games both but some games fail on SceNpMatching2GetRoomMemberDataInternalLocal because they use a static buffer size for data which is insufficient for both online name and avatar url.

@halvors
Copy link
Copy Markdown

halvors commented May 16, 2024

The titles Wolfenstein and Enemy Territory: Quake Wars had problems creating a room before (but in combination with custom servers) since they used a static buffer size mentioned above. This PR fixes that, tested with the both of them.

@RipleyTom RipleyTom force-pushed the add_match2_option branch from 2c02038 to 39afd1d Compare May 16, 2024 15:59
@RipleyTom RipleyTom marked this pull request as ready for review May 16, 2024 15:59
@Megamouse Megamouse merged commit 3e7ff40 into RPCS3:master May 16, 2024
@RipleyTom RipleyTom deleted the add_match2_option branch December 30, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants