fix basic_string warnings#16261
Merged
Merged
Conversation
|
char32_t is not allowed to contain any 32-bit value, it's only for Unicode codepoints. |
Contributor
|
Replace std::basic_string with std::vector, std::basic_string_view with std::span, avoid changing value types. |
elad335
approved these changes
Oct 30, 2024
Megamouse
reviewed
Nov 3, 2024
elad335
requested changes
Nov 3, 2024
Megamouse
reviewed
Nov 3, 2024
Megamouse
reviewed
Nov 4, 2024
elad335
reviewed
Nov 10, 2024
elad335
approved these changes
Nov 11, 2024
elad335
reviewed
Nov 12, 2024
| } | ||
|
|
||
| // Remove offsets data | ||
| id.data_view.remove_suffix(sizeof(u64) * offset_count); |
Contributor
There was a problem hiding this comment.
Lmao, I think this fixed a bug. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix the
std::basic_stringerrors when compiling with libc++19. I wasn't sure in some places whether the fix is correct which is why it is a draft. At least it build.Fixes #16259.