[Minor] Report filesizes on macOS as decimal multiples#16480
Conversation
i.e. multiples of 1000
|
This actually doesn't make sense at all. |
The function just takes in bytes though, and the raw number of bytes was never the problem, it's purely that RPCS3 currently converts from bytes to KB, KB to MB, etc in that format_bytes function using multiples of 1024. That itself is inconsistent with what macOS (and probably other OSes except Windows) do for reporting said units, hence my above example of having a supposed >10GB free disk space difference. |
|
What an OS reports is irrelevant. |
|
sorry, well. actually, it should always be KiB. |
macOS uses decimal multiples (i.e. 1KB = 1000B) for filesizes system-wide, prior to this PR it could lead to RPCS3 reporting very different values for, e.g., free disk space than what macOS itself reports elsewhere.

With the PR it'll be within a few GBs of what macOS reports in Settings (the rest of the difference is 'purgeable space' nonsense).
( I have a feeling other OSes may also report decimal multiples like macOS, and that Windows may be the odd one out in reporting binary multiples. If so then the include guards could be more broadly adjusted to only use multiples of 1024 on WIN32. )