Skip to content

Embedded SPU Image Search Fixes, Improve SPU Code Precompilation #17115

Merged
elad335 merged 1 commit into
RPCS3:masterfrom
elad335:mgs4-thaw
Apr 28, 2025
Merged

Embedded SPU Image Search Fixes, Improve SPU Code Precompilation #17115
elad335 merged 1 commit into
RPCS3:masterfrom
elad335:mgs4-thaw

Conversation

@elad335
Copy link
Copy Markdown
Contributor

@elad335 elad335 commented Apr 28, 2025

Fixes #17106

  • Allow 16-byte aligned images, 16-byte alignment is the minimum required alignment for SPU transfers.
  • Fix range lookups.
  • Fix SPU code validation that its true location and bounds are unknown.
  • Fix embedded SPU image size estimation, this allows to find nearby images which were skipped, allowing more SPU programs to be precompiled!

SPU modules found in The Last Of Us during SPU precompilation:

1853 -> 2356 SPU modules (27% improvement)

@elad335 elad335 added Bugfix Loader Involving the load of PS3 file formats labels Apr 28, 2025
@elad335 elad335 changed the title Embedded SPU Image Search Fixes Embedded SPU Image Search Fixes, Improve SPU Code Precompilation Apr 28, 2025
@elad335 elad335 merged commit 730249a into RPCS3:master Apr 28, 2025
6 of 8 checks passed
@shinra-electric
Copy link
Copy Markdown
Contributor

shinra-electric commented Apr 28, 2025

This fixed the flashlight in TLoU on macOS Arm...

Edit: Looks like that was just luck... Not working again on a subsequent load.. 🤦🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Loader Involving the load of PS3 file formats

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression] No boot for some games since #17094

2 participants