Deck editor: accessible filter dialog#6
Merged
RealAmethyst merged 1 commit intoMay 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter-dialog portion of #4, split out so it can land on its own without the virtual-toolbar work.
Summary
Makes the deck-editor Filter dialog readable with a screen reader. Adds a
FilterDialog.FilterGroupbranch toDeckHandler.OnButtonFocusedthat handles all three widget shapes the dialog uses:<group name>, <toggle label>. The group name is deduped per category so navigating 25 Type toggles in a row doesn't repeat "Type" on every step.FilterSlider) — reads min/max fromm_InputFieldWidget{Min,Max}.m_TMPInputFieldCache.text, stripping the zero-width-space placeholder that the field shows when empty. Speaks<group>, Min, <value>/<group>, Max, <value>.FilterLinkMark) — the toggles have empty visible text and aLink_1..Link_8label; N is the 1-based bit intoContent.LinkMarkerBit. Routed through the existingFormatLinkArrowsso the wording matches how link arrows are read in card readouts (e.g. "up left", "down right").