Swoole fix setAffinity call on Mac#327
Merged
Merged
Conversation
andrewdalpino
approved these changes
Apr 17, 2024
Member
andrewdalpino
left a comment
There was a problem hiding this comment.
Looks good, just wanted to confirm a couple things before we merge. See comment
|
|
||
| $workerProcess->setAffinity([$currentCpu]); | ||
| if (method_exists($workerProcess, 'setAffinity')) { | ||
| $workerProcess->setAffinity([$currentCpu]); |
Member
There was a problem hiding this comment.
So this looks like it's telling the worker process to bind to a particular unit. Is that right? Does this provide some performance enhancement? Does it still work as intended without setting the CPU affinity?
Contributor
Author
There was a problem hiding this comment.
It does work as intended; yeah it will be slower on mac because I think it will cause more context switching.
I added that on top of the other changes, so it wasn't the primary driver behind the performance gains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.