Address jcode-dev Claude review findings#7
Open
ShawnSantiago wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request increases the default RUST_MIN_STACK to 64 MiB in dev_cargo.sh to improve build resilience against stack overflow crashes. Additionally, jcode-dev.sh is updated to ensure the correct working directory is set before executing selfdev and to properly resolve the binary path when a custom CARGO_TARGET_DIR is specified. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CARGO_TARGET_DIRwhen locating the builtjcode-devbinary.JCODE_DEV_USE_SELFDEV=1.RUST_MIN_STACKdefault to 64 MiB per rustc's recommendation on fresh target builds.Validation
bash -n scripts/dev_cargo.sh scripts/jcode-dev.shenv -u RUST_MIN_STACK scripts/dev_cargo.sh --print-setup | grep 'rust_min_stack=67108864'cd /home/shawn/Documents/projects/constructive-toys-headless && jcode-dev --versionscripts/dev_cargo.sh test -p jcode-overnight-coregit diff --check origin/master...HEADNotes
CARGO_TARGET_DIRfinding and the low selfdev caller-cwd finding.CARGO_TARGET_DIRbuild progressed past the prior rustc stack SIGSEGV with 64 MiB, then hit a separate local rust-lld/toolchain link failure:unknown section type 0x24in an AWS SDK rlib. Default target builds validate successfully.