Term Count block does not handle correct product category counts with hidden products

[cr0ybot]

Description

From @Aljullu in #72313 (review):

In addition to that, the Hoodies categories shows different totals (3 vs 4) in the frontend (while both show the correct value, 3, in the editor). That's because I have one Hoodie product which is 'hidden' in the catalog.

Step-by-step reproduction instructions

1. Install the WooCommerce plugin and enable experimental blocks in the Gutenberg plugin
2. Add product categories and products and set one of the products to hidden
3. Add the Product Categories List block (from WooCommerce), the Terms List block (with show term counts), and the Terms Query block (with Term Count blocks) to a page and ensure all are set to the product category taxonomy
4. Observe that the term counts in the editor are correct for terms with hidden products but not correct on the front end

Screenshots, screen recording, code snippet

In the screenshots below, Product cat 2 includes one hidden product.

Editor:

Front end:

Environment info

• WordPress 6.8.3
• Gutenberg plugin 21.8.1

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[cr0ybot]

@Aljullu question for you:

Is WooCommerce doing some kind of filtering of term counts for the REST API and perhaps via the wp_list_categories filter? In my testing the Terms List block does show 0 for Product cat 2 which has a hidden product in it, but it still shows the term even though show empty terms is false (and there are no subterms). Right now the Term Count block just outputs term.termCount in the editor and $term->count on the front end.

[Aljullu]

@cr0ybot thanks for opening this issue, @cr0ybot!

What I found so far is that WC core is hooking into get_terms to update the counts. However, it doesn't hook into get_term to do the same, that causes the inconsistency.

The issue is visible in the Product Count block because in the editor, it uses the Rest API to get the counts, which eventually calls get_terms(), while in the frontend, the block calls get_term().

So I would say this is something that needs to be fixed in WC core. What do you think?

[cr0ybot]

So I would say this is something that needs to be fixed in WC core. What do you think?

@Aljullu That's what I'm trying to determine but it seems that way to me. The Term Count block is either using get_term() directly or get_queried_object() which uses get_term() under the hood.

[Aljullu]

Yes, let's close this issue then. I opened one in WC core: woocommerce/woocommerce#61452. Thanks for your help researching this, @cr0ybot! 🙌