CI: Add merge queue support and fix JS lint swallowing#114
Merged
Conversation
- Add merge_group trigger for GitHub merge queue integration - Run PHP tests against only bookend versions (7.4, 8.2) on PRs for faster feedback; run all versions on merge queue and trunk push - Add CI gate job as a single required status check - Remove continue-on-error from JS lint step so failures are reported - Remove dead modernize/v2 branch from push trigger
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s main CI workflow to better support GitHub’s merge queue and to ensure lint/test failures reliably fail the workflow via a single required check.
Changes:
- Add
merge_grouptrigger so CI runs for merge queue evaluations. - Adjust PHP test matrix to run only PHP 7.4 and 8.2 on PRs, while running 7.4/8.0/8.1/8.2 on
pushandmerge_group. - Add an aggregate
CIgate job and removecontinue-on-errorfrom the JS lint step so failures are not swallowed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add .eslintrc.js extending the WordPress config with JSX and DOM types (Document, Element, KeyboardEvent, MouseEvent) registered as defined types for the jsdoc/no-undefined-types rule. These errors were previously hidden by continue-on-error on the lint step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge_grouptrigger so the workflow runs in the GitHub merge queueCIgate job that aggregates all job results into a single required status checkcontinue-on-error: truefrom the JS lint step so lint failures are no longer silently swallowedmodernize/v2branch from the push triggerAfter merging
Update branch protection for
trunk:CIas the sole required status checkTest plan