64168 json schema fix#10441
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…es schema. `WP_REST_Templates_Controller::prepare_item_for_response()` can return: * `origin: null` for templates that do not come from a customizer/theme/plugin source. * `modified: false` for templates whose modified timestamp cannot be resolved. The schema declared `origin` as `string` and `modified` as `string/date-time`, so both responses failed schema validation under strict-mode REST clients. This commit widens the schema to match the runtime behavior: * `origin` becomes `[ string, null ]`. * `modified` becomes a `oneOf` of date-time string or `false`. Adds tests covering: * The `origin` schema accepts `null`. * The `modified` schema accepts both date-time string and `false`. * A theme template returns `null` for `origin` against the new schema. Complements WordPressGH-10441. See #64168.
Fix as suggested by John
Trac ticket: https://core.trac.wordpress.org/ticket/64168