Add isset() check in case source type is absent#7864
Merged
Conversation
Contributor
|
Plugin builds for 296c233 are ready 🛎️!
ChecksumsWarning These builds are for testing purposes only and should not be used in production. |
Member
Author
|
Some of the tests are failing because Gutenberg is being installed on WP 6.3, but it requires WP 6.5+ now. Other tests are failing (trivially) due to a CSS change. |
d4eef4d to
296c233
Compare
thelovekesh
approved these changes
Aug 22, 2024
Collaborator
|
Also, need to config ig there is any redundant code added for backward compatibility for WP < 6.5. But that can be part of other PR if any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7862
The only behavioral change in this PR is 66ca42e, the addition of an
isset()check. (However, it's not clear why the key isn't set in the first place.)Otherwise, it just bumps the minimum version of WP from 6.3 to 6.5 due to Gutenberg increasing its minimum required version of WP. And it fixes a test breakage due to a CSS change in the Twenty Ten theme.