Unintended Manifest Modifications by XRSessionFeatureBuildHooks for Non-AndroidXR OpenXR Platforms in Unity

[davidschrottsap]

Hi Google Team,
we have noticed an issue with the XRSessionFeatureBuildHooks Class in Unity Projects that use the OpenXR plugin across multiple plattforms.

When the AndroidXR Package is present in the project, the class injects additional configurations in the manifest files on build time, regardless of whether the current build target is AndroidXR or another OpenXR Plattform.

Currently the compiler flag UNITY_OPEN_XR_ANDROID_XR is defined as soon as the AndroidXR package is included in the project, rather than being conditional on the actual build profile. As a result, AndroidXRBuildUtils.IsUnityAndroidXRActive() always returns true, leading to unwanted manifest modifications for non AndroidXR builds.

Please adjust the detection logic in ProvideManifestRequirement() and AndroidXRBuildUtils.IsUnityAndroidXRActive(), so that they only modify the manifest and return true respectively when the active build target is AndroidXR.

Thanks

Best regards
David Schrott
SAP SE

[LevanaChen]

AndroidXRBuildUtils.IsUnityAndroidXRActive() does check the active build target when you have Unity's Android XR package imported:

#if UNITY_OPEN_XR_ANDROID_XR
            var featureIds = OpenXRFeatureSetManager.GetFeatureSetWithId(
                BuildTargetGroup.Android, _unityAndroidXRFeatureSetId).featureIds;
            var openXRFeatures = FeatureHelpers.GetFeaturesWithIdsForBuildTarget(
                BuildTargetGroup.Android, featureIds);

            var isAnyFeatureActive = openXRFeatures.Any(feature => feature.enabled);

            return isAnyFeatureActive &&
                EditorUserBuildSettings.activeBuildTarget == BuildTarget.Android;
#else

Could you provide example with reproduce steps so that we can compare the actual result vs expectation?

[davidschrottsap]

Hi @LevanaChen ,

thanks for your message.

To reproduce this for example use any OpenXR Unity App. We are working on 6.1.2f1 at the moment):

• add the OpenXR Meta package (https://docs.unity3d.com/Packages/com.unity.xr.meta-openxr@2.1/manual/index.html)
• Set in the Project Settings under XR Plugin Management for Android Build Target. The Meta Quest feature group and disable the AndroidXR feature group
• Build for Meta Quest Build Profile

You will see these manifest modification logs in the build process, coming from XRSessionFeatureBuildHooks.cs

I just briefly looked at the code from AndroidXRBuildUtils.IsUnityAndroidXRActive() and XRSessionFeatureBuildHooks

The issue is that ProvideManifestRequirement() does not check if the currently active OpenXR feature group is the AndroidXR group. To my understanding, it only checks if any of the openXR features are enabled, regardless of the selected feature group.

Best regards
David