Skip to content

Drop isSupported injection, bump rxfire #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2024
Merged

Drop isSupported injection, bump rxfire #3588

merged 3 commits into from
Dec 12, 2024

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Dec 12, 2024 •
edited
Loading

  • Bump rxfire dep
  • Drop isSupported inject in favor of PLATFORM_ID test
  • Analytics is technically isPlatformBrowser rather than !isPlatformServer, prolly no diff

@jamesdaniels jamesdaniels merged commit 6b1b0ca into angular:main Dec 12, 2024
6 checks passed
@jamesdaniels jamesdaniels deleted the jamesdaniels_rxFireIsSupported branch December 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesdaniels