Fix BigQueryToGCSOperator by waiting insert_job result in normal mode #29925
+2
β2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
uranusjr
approved these changes
Mar 5, 2023
potiuk
approved these changes
Mar 5, 2023
|
BTW. @Taragolis seems we have the docker-compose flaky test back :( |
|
Ah. No. Seems that is side effect of the "importilb 5.0.0" issue : #29924. It should be fine now after it's merged. Let me rebase and try. |
feb7c31 to
becf530
Compare
|
@hussein-awala thanks for fixing this so quickly! |
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29912
In deferrable mode, we should not wait the job result in the worker, instead we create a trigger and we wait the end of the job in the triggerer, and this is what we do currently. But in the normal mode, we should wait it in the worker, otherwise the task finishes immediately with success state regardless the state of the job and its duration.