Skip to content

GH-38554: [Release][Website] post-03-website.sh doesn't quote current.date#38555

Merged
kou merged 1 commit into
apache:mainfrom
kou:release-post-03-website-quote
Nov 2, 2023
Merged

GH-38554: [Release][Website] post-03-website.sh doesn't quote current.date#38555
kou merged 1 commit into
apache:mainfrom
kou:release-post-03-website-quote

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Nov 2, 2023

Rationale for this change

We should not quote the value to process the value as a date value.

What changes are included in this PR?

Remove needless quotation.

Are these changes tested?

No.

Are there any user-facing changes?

No.

…urrent.date

We should not quote the value to process the value as a date value.
@kou kou requested review from assignUser and raulcd as code owners November 2, 2023 03:15
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 2, 2023

⚠️ GitHub issue #38554 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Nov 2, 2023
Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou this looks good to me. Just so I understand, what is the problem with quotation? Is it just unnecessary or it causes an issue? I'm asking only to understand if there's an issue.

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 2, 2023
@kou
Copy link
Copy Markdown
Member Author

kou commented Nov 2, 2023

It may cause an issue. We use the value in https://github.com/apache/arrow-site/blob/69bcbde1906af9e1b463484cdb1528986210ca89/arrow.rdf#L65 . It uses the value as-is for now. So both of "2023-11-01" (string) and 2023-11-01 (date) work. But if want to change output format, we can't do it with a string. We need a date value for it.

FYI:

If we quote, the value is processed as a string:

$ ruby -r date -r yaml -e 'pp YAML.safe_load("date: \"2023-11-01\"", permitted_classes: [Date])'
{"date"=>"2023-11-01"}

If we don't quote, the value is processed as a date:

$ ruby -r date -r yaml -e 'pp YAML.safe_load("date: 2023-11-01", permitted_classes: [Date])'
{"date"=>#<Date: 2023-11-01 ((2460250j,0s,0n),+0s,-Infj)>}

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Nov 2, 2023
@kou kou merged commit 4fa7f03 into apache:main Nov 2, 2023
@kou kou deleted the release-post-03-website-quote branch November 2, 2023 18:20
@kou kou removed the awaiting merge Awaiting merge label Nov 2, 2023
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4fa7f03.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…urrent.date (apache#38555)

### Rationale for this change

We should not quote the value to process the value as a date value.

### What changes are included in this PR?

Remove needless quotation.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#38554

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…urrent.date (apache#38555)

### Rationale for this change

We should not quote the value to process the value as a date value.

### What changes are included in this PR?

Remove needless quotation.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#38554

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Release][Website] post-03-website.sh uses needless quotation for current.date

2 participants