GH-38554: [Release][Website] post-03-website.sh doesn't quote current.date#38555
Conversation
…urrent.date We should not quote the value to process the value as a date value.
|
|
|
It may cause an issue. We use the value in https://github.com/apache/arrow-site/blob/69bcbde1906af9e1b463484cdb1528986210ca89/arrow.rdf#L65 . It uses the value as-is for now. So both of FYI: If we quote, the value is processed as a string: $ ruby -r date -r yaml -e 'pp YAML.safe_load("date: \"2023-11-01\"", permitted_classes: [Date])'
{"date"=>"2023-11-01"}If we don't quote, the value is processed as a date: $ ruby -r date -r yaml -e 'pp YAML.safe_load("date: 2023-11-01", permitted_classes: [Date])'
{"date"=>#<Date: 2023-11-01 ((2460250j,0s,0n),+0s,-Infj)>} |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4fa7f03. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…urrent.date (apache#38555) ### Rationale for this change We should not quote the value to process the value as a date value. ### What changes are included in this PR? Remove needless quotation. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#38554 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…urrent.date (apache#38555) ### Rationale for this change We should not quote the value to process the value as a date value. ### What changes are included in this PR? Remove needless quotation. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#38554 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
We should not quote the value to process the value as a date value.
What changes are included in this PR?
Remove needless quotation.
Are these changes tested?
No.
Are there any user-facing changes?
No.