GH-38824: [Go] Enable GC checks#38826
Merged
Merged
Conversation
|
|
Member
Author
|
I wonder if this is making Go CI builds slower than they were. I see a ton of |
Member
Author
Answer: CI builds seem roughly the same duration as before. |
3b9143b to
79e0988
Compare
Member
Author
|
@github-actions crossbow submit -g go |
|
Revision: 29bf1db Submitted crossbow builds: ursacomputing/crossbow @ actions-ed99c57b77
|
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1cd22df. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### What changes are included in this PR? Our codebase has many uses of `unsafe.Pointer`. It may be a good idea to add debug checks for these uses in CI builds, especially where data crosses C boundaries. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38824 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Our codebase has many uses of
unsafe.Pointer. It may be a good idea to add debug checks for these uses in CI builds, especially where data crosses C boundaries.Are these changes tested?
Yes.
Are there any user-facing changes?
No.