GH-38852: [C++] Replace "#ifdef ARROW_WITH_GZIP" in dataset test to ARROW_WITH_ZLIB#38853
Merged
Conversation
|
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 8e28f6b. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…t to ARROW_WITH_ZLIB (apache#38853) ### Rationale for this change We don't define `ARROW_WITH_GZIP` macro when we can use gzip. We use `ARROW_WITH_ZLIB` instead. So `ARROW_WITH_ZLIB` is always not defined. ### What changes are included in this PR? change `ARROW_WITH_GZIP` to `ARROW_WITH_ZLIB` ### Are these changes tested? previously not tested, but now there're ### Are there any user-facing changes? no * Closes: apache#38852 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We don't define
ARROW_WITH_GZIPmacro when we can use gzip. We useARROW_WITH_ZLIBinstead. SoARROW_WITH_ZLIBis always not defined.What changes are included in this PR?
change
ARROW_WITH_GZIPtoARROW_WITH_ZLIBAre these changes tested?
previously not tested, but now there're
Are there any user-facing changes?
no