[BEAM-11032] Use metric for Java BigQuery streaming insert API latenc⦠#13491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
R: @ajamato Uses Metrics for logging latencies instead of parameters. Reverted BigQueryService API signature changes for histogram and counter. |
|
@ajamato PTAL |
|
@ajamato Friendly ping |
ajamato
reviewed
Jan 12, 2021
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/DelegatingCounter.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/beam/sdk/extensions/gcp/util/LatencyRecordingHttpRequestInitializer.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/Metrics.java
Outdated
Show resolved
Hide resolved
ajamato
reviewed
Jan 12, 2021
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsLogger.java
Show resolved
Hide resolved
|
@pabloem Would you take a look as well, as a committer. Or lmk if you have someone else in mind on the java side. |
|
Run Java PreCommit |
ajamato
approved these changes
Jan 14, 2021
| @@ -383,4 +409,70 @@ public boolean equals(@Nullable Object object) { | |||
| public int hashCode() { | |||
| return Objects.hash(stepName, counters, distributions, gauges); | |||
| } | |||
|
|
|||
| private boolean equalsMetricName(MetricName metricName, String namespace, String name) { | |||
| return (namespace == null || namespace.equals(metricName.getNamespace())) | |||
There was a problem hiding this comment.
This equality looks werid, why would it be considered equal if the param is null?
Can you add a clairifying comment
There was a problem hiding this comment.
Yeah, equals prefix is misleading. It's more like matching and when the field will be ignored when the parameter is null. I renamed the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β¦y logging
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.