Skip to content

fixed exceptions handling during shutdown #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2021
Merged

fixed exceptions handling during shutdown #400

merged 3 commits into from
Jun 30, 2021

Conversation

rashtao
Copy link
Collaborator

@rashtao rashtao commented Jun 29, 2021

Improved exception handling during shutdown by:

  • removing requests to acquire the host list before shutdown and caching the last acquire host list
  • closing connections in finally block

fixes #399

@rashtao rashtao mentioned this pull request Jun 29, 2021
Closed
@rashtao rashtao merged commit 599b9c5 into master Jun 30, 2021
@rashtao rashtao deleted the bugfix/safe_shutdown branch July 19, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wajda wajda wajda left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception thrown from "executor.disconnect()" leads to CommunicationProtocol remaining open
2 participants
@rashtao @wajda