Skip to content

[DE-876] added missing statistics to CursorStats: documentLookups, intermediat… #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

[DE-876] added missing statistics to CursorStats: documentLookups, intermediat… #580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79a3289
added missing statistics to CursorStats: documentLookups, intermediat…
rashtao Oct 22, 2024
c257413
test fix
rashtao Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test fix
  • Loading branch information
@rashtao
rashtao committed Oct 22, 2024
commit c2574138bd4425de5b04c4a751d5dfe36473bbc9
6 changes: 4 additions & 2 deletions test-functional/src/test/java/com/arangodb/ArangoDatabaseAsyncTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,9 +630,11 @@ void queryStats(ArangoDatabaseAsync db) throws ExecutionException, InterruptedEx
assertThat(cursor.getExtra().getStats().getFiltered()).isNotNull();
assertThat(cursor.getExtra().getStats().getExecutionTime()).isNotNull();
assertThat(cursor.getExtra().getStats().getPeakMemoryUsage()).isNotNull();
assertThat(cursor.getExtra().getStats().getDocumentLookups()).isNotNull();
assertThat(cursor.getExtra().getStats().getIntermediateCommits()).isNotNull();
assertThat(cursor.getExtra().getStats().getSeeks()).isNotNull();
if (isAtLeastVersion(3, 12)) {
assertThat(cursor.getExtra().getStats().getDocumentLookups()).isNotNull();
assertThat(cursor.getExtra().getStats().getSeeks()).isNotNull();
}
}

@ParameterizedTest
Expand Down
6 changes: 4 additions & 2 deletions test-functional/src/test/java/com/arangodb/ArangoDatabaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,11 @@ void queryStats(ArangoDatabase db) {
assertThat(cursor.getStats().getCursorsRearmed()).isNotNull();
assertThat(cursor.getStats().getCacheHits()).isNotNull();
assertThat(cursor.getStats().getCacheMisses()).isNotNull();
assertThat(cursor.getStats().getDocumentLookups()).isNotNull();
assertThat(cursor.getStats().getIntermediateCommits()).isNotNull();
assertThat(cursor.getStats().getSeeks()).isNotNull();
if (isAtLeastVersion(3, 12)) {
assertThat(cursor.getStats().getDocumentLookups()).isNotNull();
assertThat(cursor.getStats().getSeeks()).isNotNull();
}
}

@ParameterizedTest
Expand Down