Skip to content

H7 Video: bugfixes #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

H7 Video: bugfixes #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b6eecf
sdram: reduce pins drive strength
facchinm Sep 2, 2025
71e572c
anx7625: don't fail horribly if EDID is non conformant
facchinm Sep 2, 2025
1bcaa95
H7Video: allow EDID_MODE_AUTO
facchinm Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/Arduino_H7_Video/src/anx7625.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,8 @@ int anx7625_dp_get_edid(uint8_t bus, struct edid *out) {

ret = decode_edid(edid, (block_num + 1) * ONE_BLOCK_SIZE, out);
if (ret != EDID_CONFORMANT) {
ANXERROR("Failed to decode EDID.\n");
return -1;
ANXINFO("Non conformant EDID.\n");
return 0;
}

return 0;
Expand Down
9 changes: 4 additions & 5 deletions libraries/Arduino_H7_Video/src/video_modes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ struct envie_edid_mode envie_known_modes[NUM_KNOWN_MODES] = {

enum edid_modes video_modes_get_edid(uint32_t h_check, uint32_t v_check) {
int sum = 0;
int sel_mode = -1;
int sel_mode = EDID_MODE_AUTO;
int sel_sum = 0;

for (int i = 0; i<NUM_KNOWN_MODES; i++) {
Expand All @@ -74,7 +74,7 @@ enum edid_modes video_modes_get_edid(uint32_t h_check, uint32_t v_check) {
sum = -1;
}

if (sum >= 0 && ((sel_mode == -1) || (sum < sel_sum))) {
if (sum >= 0 && ((sel_mode == EDID_MODE_AUTO) || (sum < sel_sum))) {
sel_mode = i;
sel_sum = sum;
}
Expand All @@ -88,14 +88,13 @@ enum edid_modes video_modes_get_edid(uint32_t h_check, uint32_t v_check) {
sum = -1;
}

if (sum >= 0 && ((sel_mode == -1) || (sum < sel_sum))) {
if (sum >= 0 && ((sel_mode == EDID_MODE_AUTO) || (sum < sel_sum))) {
sel_mode = i;
sel_sum = sum;
}
}

if (sel_mode == -1 ||
sel_mode == EDID_MODE_1280x768_60Hz ||
if (sel_mode == EDID_MODE_1280x768_60Hz ||
sel_mode == EDID_MODE_1280x720_60Hz ||
sel_mode == EDID_MODE_1920x1080_60Hz) {
sel_mode = EDID_MODE_1024x768_60Hz;
Expand Down
2 changes: 1 addition & 1 deletion libraries/Portenta_SDRAM/src/ram_internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ bool sdram_init(void) {
/* Common GPIO configuration */
gpio_init_structure.Mode = GPIO_MODE_AF_PP;
gpio_init_structure.Pull = GPIO_PULLUP;
gpio_init_structure.Speed = GPIO_SPEED_FREQ_VERY_HIGH;
gpio_init_structure.Speed = GPIO_SPEED_FREQ_MEDIUM;
gpio_init_structure.Alternate = GPIO_AF12_FMC;

/* GPIOD configuration */
Expand Down