Skip to content

Add support for DHCP hostname #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add support for DHCP hostname #921

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85f6572
patches: add dhcp hostname support
Channel59 Jul 9, 2024
09ca461
Add setHostname() method to Ethernet.cpp
Channel59 Jul 9, 2024
6d45bb7
Fix missed ;
Channel59 Jul 9, 2024
74a9a6d
rebuild OPTA variant
Channel59 Jul 9, 2024
e4bec35
Fix compatibility with Ethernet.begin(nullptr) by removing begin(cons…
Channel59 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix compatibility with Ethernet.begin(nullptr) by removing begin(cons… 
…t char* hostname) method.
  • Loading branch information
@Channel59
Channel59 committed Jul 9, 2024
commit e4bec356ddfdac06580b5ff2dd22ac232af426a8
6 changes: 0 additions & 6 deletions libraries/Ethernet/src/Ethernet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ int arduino::EthernetClass::setHostname(const char* hostname) {
return 1;
}

int arduino::EthernetClass::begin(const char* hostname) {
eth_if->set_hostname(hostname);
auto ret = begin();
return ret;
}

int arduino::EthernetClass::begin(uint8_t *mac, IPAddress ip) {
IPAddress dns = ip;
dns[3] = 1;
Expand Down
1 change: 0 additions & 1 deletion libraries/Ethernet/src/Ethernet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ class EthernetClass : public MbedSocketClass {
// gain the rest of the configuration through DHCP.
// Returns 0 if the DHCP configuration failed, and 1 if it succeeded
int begin(uint8_t *mac = nullptr, unsigned long timeout = 60000, unsigned long responseTimeout = 4000);
int begin(const char* hostname);
EthernetLinkStatus linkStatus();
EthernetHardwareStatus hardwareStatus();

Expand Down