Skip to content

Allow downloading index and signature in a single tar.bz2 archive #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 24, 2022
Merged

Allow downloading index and signature in a single tar.bz2 archive #1734

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8106388
Allow downloading index and signature in a tar.bz2 archive
cmaglie May 17, 2022
bc0d42a
Make some configurations resilient to empty settings
cmaglie May 17, 2022
b3ee537
Added tests
cmaglie May 17, 2022
a2f73e1
fix comment
cmaglie May 17, 2022
f57e747
Apply suggestions from code review
cmaglie May 18, 2022
17322bb
Allow .tar.bz2 package index URL
cmaglie May 19, 2022
de2ae46
Fix errors in timeout checks
cmaglie May 20, 2022
7d14f3c
Fixed check for stale package_index.json files
cmaglie May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make some configurations resilient to empty settings
  • Loading branch information
@cmaglie
cmaglie committed May 20, 2022
commit bc0d42ab5202087580b8313b5e76382f39571ac6
7 changes: 5 additions & 2 deletions configuration/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ import (

// UserAgent returns the user agent (mainly used by HTTP clients)
func UserAgent(settings *viper.Viper) string {
subComponent := settings.GetString("network.user_agent_ext")
subComponent := ""
if settings != nil {
subComponent = settings.GetString("network.user_agent_ext")
}
if subComponent != "" {
subComponent = " " + subComponent
}
Expand All @@ -41,7 +44,7 @@ func UserAgent(settings *viper.Viper) string {

// NetworkProxy returns the proxy configuration (mainly used by HTTP clients)
func NetworkProxy(settings *viper.Viper) (*url.URL, error) {
if !settings.IsSet("network.proxy") {
if settings == nil || !settings.IsSet("network.proxy") {
return nil, nil
}
if proxyConfig := settings.GetString("network.proxy"); proxyConfig == "" {
Expand Down