Skip to content

[breaking] core update-index do not stop at the first download error #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 9, 2022
Merged

[breaking] core update-index do not stop at the first download error #1866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1da3b29
Added flag to skip 3rd party package_index in UpdateIndex gRPC API
cmaglie Sep 6, 2022
d3356cc
UpdateIndex gRPC call does not stop at the first error
cmaglie Sep 6, 2022
c728242
Updated docs
cmaglie Sep 6, 2022
732bdc5
Fixed integration tests
cmaglie Sep 6, 2022
c1f7fd5
Ensure that a 'Completed' download progress is always sent
cmaglie Sep 7, 2022
84642ef
UpdateIndex: Fixed a wrong success report and added test.
cmaglie Sep 7, 2022
9fddd77
Improved test error messages
cmaglie Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added flag to skip 3rd party package_index in UpdateIndex gRPC API 
Fix #1788
  • Loading branch information
@cmaglie
cmaglie committed Sep 6, 2022
commit 1da3b296ce4c62f990c1efeffddbd18df14275c9
3 changes: 2 additions & 1 deletion cli/instance/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ func FirstUpdate(instance *rpc.Instance) error {
if packageIndex.NotExist() {
_, err := commands.UpdateIndex(context.Background(),
&rpc.UpdateIndexRequest{
Instance: instance,
Instance: instance,
IgnoreCustomPackageIndexes: true,
},
output.ProgressBar(),
)
Expand Down
4 changes: 3 additions & 1 deletion commands/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,9 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB rp
indexpath := configuration.DataDir(configuration.Settings)

urls := []string{globals.DefaultIndexURL}
urls = append(urls, configuration.Settings.GetStringSlice("board_manager.additional_urls")...)
if !req.GetIgnoreCustomPackageIndexes() {
urls = append(urls, configuration.Settings.GetStringSlice("board_manager.additional_urls")...)
}
for _, u := range urls {
logrus.Info("URL: ", u)
URL, err := utils.URLParse(u)
Expand Down
Loading