Skip to content

Prevent duplicate entries in board_manager.additional_urls #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Prevent duplicate entries in board_manager.additional_urls #1902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
861919e
uniquify configuration arrays in `config add`
henrygab Oct 2, 2022
9fb7b17
Add tests for unique board manager URLs
henrygab Oct 2, 2022
370f637
fix linting
henrygab Oct 2, 2022
24acf27
lint: update function name
henrygab Oct 2, 2022
dd85466
update config set to uniquify slices
henrygab Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update config set to uniquify slices
  • Loading branch information
@henrygab
henrygab committed Oct 2, 2022
commit dd854665717844fb7fb40c8c55402a409e04bf01
5 changes: 0 additions & 5 deletions cli/config/add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,7 @@ func runAddCommand(cmd *cobra.Command, args []string) {
}

v := configuration.Settings.GetStringSlice(key)
// only insert values that do not already exist
// old code appended all except the first arg (which was the key)
v = append(v, args[1:]...)
// v now has the original values + the appended values
// but, the appended values might have already existed
// if so, remove them.
v = uniquifyStringSlice(v)
configuration.Settings.Set(key, v)

Expand Down
2 changes: 1 addition & 1 deletion cli/config/set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func runSetCommand(cmd *cobra.Command, args []string) {
var value interface{}
switch kind {
case reflect.Slice:
value = args[1:]
value = uniquifyStringSlice(args[1:])
case reflect.String:
value = args[1]
case reflect.Bool:
Expand Down