Skip to content

Add task to collect proto files and add steps to release them with tester, nightly and stable builds #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Add task to collect proto files and add steps to release them with tester, nightly and stable builds #1931

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce44ee4
Add task to zip all .proto files for release
silvanocerza Oct 19, 2022
d79ec48
Add proto files in nightly released files
silvanocerza Oct 19, 2022
0c44da8
Add proto files in tester released files
silvanocerza Oct 19, 2022
ee09913
Add proto files in stable released files
silvanocerza Oct 19, 2022
32c1c30
Fix tester build workflow
silvanocerza Oct 19, 2022
bbb662a
Fix checksums.txt creation in tester and stable build releases
silvanocerza Oct 20, 2022
ab741fd
Change build job of tester build workflow to be generic
silvanocerza Oct 25, 2022
a8bd158
Fix Publish Tester Build job dependencies
silvanocerza Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tester build workflow
  • Loading branch information
@silvanocerza
silvanocerza committed Oct 19, 2022
commit 32c1c30f5d50442c1017be2ffdea8e694a7e7622
58 changes: 32 additions & 26 deletions .github/workflows/publish-go-tester-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,32 +132,6 @@ jobs:
path: ${{ env.DIST_DIR }}/${{ matrix.os.path }}
name: ${{ matrix.os.name }}

proto-files:
needs:
- package-name-prefix
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Install Task
uses: arduino/setup-task@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Collect proto files
run: task protoc:collect

- name: Upload proto files zip
uses: actions/upload-artifact@v3
with:
path: ${{ env.DIST_DIR }}/*.zip
name: rpc-protocol-files

checksums:
needs:
- build
Expand Down Expand Up @@ -185,3 +159,35 @@ jobs:
with:
path: ./*checksums.txt
name: checksums

proto-files:
# Run this after checksums or the uploaded proto files zip
# will make the checksum job always fail
needs:
- checksums
- package-name-prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why checksums is failing? shouldn't just add the checksum of the protoc archive to the checksums file together with the other archives?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about that, it would make sense since it's a file part of the release. 🤔
I'd have to edit a bit the checksum process I think, I'll take a look at it.

runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Install Task
uses: arduino/setup-task@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Collect proto files
run: |
PACKAGE_NAME_PREFIX=${{ needs.package-name-prefix.outputs.prefix }}
export PACKAGE_NAME_PREFIX
task protoc:collect

- name: Upload proto files zip
uses: actions/upload-artifact@v3
with:
path: ${{ env.DIST_DIR }}/*.zip
name: rpc-protocol-files