Skip to content

Improved compile speed by running multi-threaded library discovery. #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 25, 2025
Merged

Improved compile speed by running multi-threaded library discovery. #2625

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
97451d8
Simplified error reporting in library detection
cmaglie May 31, 2024
9b7b9d2
Remove useless targetFilePath variable
cmaglie Jun 1, 2024
a75945a
Slight improvement of removeBuildFromSketchFiles
cmaglie Jun 2, 2024
c00b637
Rename variables for clarity
cmaglie Jun 2, 2024
ddd1e5b
Removed hardcoded build.warn_data_percentage in build.options file
cmaglie Jun 2, 2024
688f28f
Renamed variables for clarity
cmaglie Jun 2, 2024
7eb04d0
Renamed variables for clarity
cmaglie Jun 2, 2024
ba8b764
Pre-compute sourceFile fields, and save the in the includes.cache
cmaglie Jun 3, 2024
eee25d1
Added ObjFileIsUpToDate method to sourceFile
cmaglie Jun 3, 2024
6247a03
Implemented parallel task runner
cmaglie Jun 4, 2024
8013f91
Simplify use of properties.SplitQuotedString
cmaglie Jun 4, 2024
142c297
Use runner.Task in GCC preprocessor
cmaglie Jun 5, 2024
14a3adb
Parallelize library discovery phase in compile
cmaglie Jun 5, 2024
b8f94f5
The number of jobs in library detection now follows --jobs flag
cmaglie Jun 11, 2024
d0d4173
Reordered properties construction for clarity
cmaglie Jun 13, 2024
0579d02
Reordered compileFileWithRecipe for clarity
cmaglie Jun 13, 2024
b717a2a
Added integration test
cmaglie Jun 12, 2024
7241f25
fix: libraries are recompiled if the list of include paths changes
cmaglie Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reordered properties construction for clarity
  • Loading branch information
@cmaglie
cmaglie committed Jul 14, 2025
commit d0d41738ac8f58f18ca577b21d975a31e49c1a5c
14 changes: 6 additions & 8 deletions internal/arduino/builder/compilation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,20 +119,13 @@ func (b *Builder) compileFileWithRecipe(
includes []string,
recipe string,
) (*paths.Path, error) {
properties := b.buildProperties.Clone()
properties.Set("compiler.warning_flags", properties.Get("compiler.warning_flags."+b.logger.WarningsLevel()))
properties.Set("includes", strings.Join(includes, " "))
properties.SetPath("source_file", source)
relativeSource, err := sourcePath.RelTo(source)
if err != nil {
return nil, err
}
depsFile := buildPath.Join(relativeSource.String() + ".d")
objectFile := buildPath.Join(relativeSource.String() + ".o")

properties.SetPath("object_file", objectFile)
err = objectFile.Parent().MkdirAll()
if err != nil {
if err := objectFile.Parent().MkdirAll(); err != nil {
return nil, err
}

Expand All @@ -141,6 +134,11 @@ func (b *Builder) compileFileWithRecipe(
return nil, err
}

properties := b.buildProperties.Clone()
properties.Set("compiler.warning_flags", properties.Get("compiler.warning_flags."+b.logger.WarningsLevel()))
properties.Set("includes", strings.Join(includes, " "))
properties.SetPath("source_file", source)
properties.SetPath("object_file", objectFile)
command, err := b.prepareCommandForRecipe(properties, recipe, false)
if err != nil {
return nil, err
Expand Down