Skip to content

Implement debug feature #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Feb 21, 2020
Merged

Implement debug feature #590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3e861b7
Implement first draft of debugger gRPC service
Feb 14, 2020
0119a90
Working stdio streaming
cmaglie Feb 17, 2020
a106a4f
Improved stdio passing via GRPC
cmaglie Feb 17, 2020
b16874d
Adjusted protoc definitions
cmaglie Feb 17, 2020
d9077eb
Handle errors gracefully
cmaglie Feb 17, 2020
e86ae80
Add recipe calculation to debug command
Feb 17, 2020
879367b
First implementation of debug
cmaglie Feb 17, 2020
7648814
updated client example for testing
Feb 17, 2020
3960fea
Implement debug command
Feb 19, 2020
5228709
Implement copyStream
Feb 19, 2020
9d314ab
Refactor stream helpers
Feb 19, 2020
8d44e6f
Extract recipe creation from debug command
Feb 19, 2020
9923f62
Add test for debug recipe generation
Feb 19, 2020
378b8bf
Cosmetics here and there
Feb 19, 2020
74fa6df
Refreshed client example
Feb 19, 2020
e8d9071
Replace with utils function
Feb 20, 2020
3888017
Remove debug leftover
Feb 20, 2020
e0e07c5
Refreshed client example
Feb 20, 2020
c2681b3
Moved debug proto to its package
Feb 20, 2020
11452d5
Removed sketch.json
Feb 20, 2020
a85376f
Apply general cosmetics
Feb 20, 2020
83cf94e
Add test binaries
Feb 20, 2020
da07d3d
Added test case for windows path flavor
Feb 20, 2020
abc9353
Use path.FromSlash to test debug tool command generation cross platfo…
Feb 21, 2020
fa39675
Avoid pipe leaking via closing readers and writes in case of abnormal…
Feb 21, 2020
3650865
Update client example to better catch gdb prompt
Feb 21, 2020
34e7854
Error messages cosmetics
Feb 21, 2020
5d9be12
Use errors.Wrap instead of fmt.Errorf
cmaglie Feb 21, 2020
600c1d5
Use errors.Wrap instead of fmt.Errorf
cmaglie Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moved debug proto to its package
  • Loading branch information
rsora committed Feb 21, 2020
commit c2681b35fe1774077f53c948763c5db64a285811
90 changes: 4 additions & 86 deletions rpc/commands/commands.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading