Skip to content

add basic implementation of tab completion #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 12, 2020
Merged

add basic implementation of tab completion #663

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d5fa860
add basic implementation of bash completion
umbynos Apr 18, 2020
cdefe24
update cobra to 1.0.0 because of https://github.com/spf13/cobra/pull/…
umbynos Apr 19, 2020
34ac811
add support for zsh and fish, improved help messages
umbynos Apr 19, 2020
7e661fa
add flag ´--no-descriptions´ to disable automatic command description…
umbynos Apr 26, 2020
fe15901
fix fish not supporting env variables with dash in the name
umbynos Apr 26, 2020
b6fd1d7
fixed zsh completion not working
umbynos May 4, 2020
054ae56
revert "#compdef" patch
umbynos May 21, 2020
526a2dd
add check on --no-description flag
umbynos Jun 1, 2020
07f2489
add docs
umbynos Jun 8, 2020
aabfda3
Apply suggestions from code review
umbynos Jun 9, 2020
875610f
forgot a space
umbynos Jun 9, 2020
a589a7b
fix fish docs
umbynos Jun 9, 2020
c8ed341
add test for completion
umbynos Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert "#compdef" patch
  • Loading branch information
@umbynos
umbynos committed Jun 8, 2020
commit 054ae56ece30fe2c801df4fda0c2e564b1b78e17
3 changes: 1 addition & 2 deletions cli/completion/completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,8 @@ func run(cmd *cobra.Command, args []string) {
case "zsh":
buf := new(bytes.Buffer)
cmd.Root().GenZshCompletion(buf)
s := strings.Replace(buf.String(), "#", "", 1) //remove the comment from compdef
r := strings.NewReplacer("[", "\\[", "]", "\\]") //insert escaping before [ and ]
s = r.Replace(s)
s := r.Replace(buf.String())
s = strings.ReplaceAll(s, "\\[1\\]", "[1]") // revert the case
os.Stdout.WriteString(s)
break
Expand Down