Skip to content

feat(all): make @middy/core optional #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 26, 2022
Merged

feat(all): make @middy/core optional #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ea26b6
feat(tracer): moved middy as devDep + updated docs
dreamorosi Jan 25, 2022
333c3df
feat(tracer): simplified middy note in docs
dreamorosi Jan 25, 2022
20d71da
feat(metrics): moved middy as devDep + updated docs
dreamorosi Jan 25, 2022
1265f57
feat(logger): moved middy as devDep + updated docs
dreamorosi Jan 25, 2022
98c321f
chore(examples): bumped middy to latest 2.x
dreamorosi Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs/core/logger.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,8 @@ Key | Example

=== "Middy Middleware"

!!! note
Middy comes bundled with Logger, so you can just import it when using the middleware.

!!! tip "Using Middy for the first time?"
You can install Middy by running `npm i @middy/core`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the shout out

Learn more about [its usage and lifecycle in the official Middy documentation](https://github.com/middyjs/middy#usage){target="_blank"}.

```typescript hl_lines="1-2 10-11"
Expand Down
4 changes: 1 addition & 3 deletions docs/core/metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,8 @@ You can add default dimensions to your metrics by passing them as parameters in

=== "Middy middleware"

!!! note
Middy comes bundled with Metrics, so you can just import it when using the middleware.

!!! tip "Using Middy for the first time?"
You can install Middy by running `npm i @middy/core`.
Learn more about [its usage and lifecycle in the official Middy documentation](https://github.com/middyjs/middy#usage){target="_blank"}.

```typescript hl_lines="1-2 11 13"
Expand Down
4 changes: 1 addition & 3 deletions docs/core/tracer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,8 @@ You can quickly start by importing the `Tracer` class, initialize it outside the

=== "Middy Middleware"

!!! note
Middy comes bundled with Tracer, so you can just import it when using the middleware.

!!! tip "Using Middy for the first time?"
You can install Middy by running `npm i @middy/core`.
Learn more about [its usage and lifecycle in the official Middy documentation](https://github.com/middyjs/middy#usage){target="_blank"}.

```typescript hl_lines="1-2 11 13"
Expand Down
Loading