[Fix] Switch to subprocess in ModelBuilder when capturing dependencies#4556
Merged
Conversation
samruds
approved these changes
Apr 2, 2024
Collaborator
|
Minor just update the title and description : progress -> process |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4556 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 389 389
Lines 36888 36889 +1
=======================================
+ Hits 32256 32257 +1
Misses 4632 4632 ☔ View full report in Codecov by Sentry. |
akrishna1995
reviewed
Apr 2, 2024
| logging.info("Running command: %s", " ".join(command)) | ||
|
|
||
| os.system(command) | ||
| subprocess.run(command, check=True, capture_output=True) |
Contributor
There was a problem hiding this comment.
Should we write a UT for test? Can you confirm how this was tested
akrishna1995
approved these changes
Apr 2, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
malav-shastri
pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
aws#4556) * [Fix] Switch to subprogress in ModelBuilder when capturing dependencies * Fix style issues and explicitly set check to true
jiapinw
added a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
aws#4556) * [Fix] Switch to subprogress in ModelBuilder when capturing dependencies * Fix style issues and explicitly set check to true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.