Skip to content

Fix remainder by zero#882

Merged
Razican merged 2 commits into
boa-dev:masterfrom
georgeroman:fix_rem_by_zero
Oct 18, 2020
Merged

Fix remainder by zero#882
Razican merged 2 commits into
boa-dev:masterfrom
georgeroman:fix_rem_by_zero

Conversation

@georgeroman
Copy link
Copy Markdown
Contributor

Fixes #780

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2020

Codecov Report

Merging #882 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   59.30%   59.31%   +0.01%     
==========================================
  Files         165      165              
  Lines       10342    10381      +39     
==========================================
+ Hits         6133     6158      +25     
- Misses       4209     4223      +14     
Impacted Files Coverage Δ
boa/src/value/operations.rs 47.29% <83.33%> (+0.56%) ⬆️
boa/src/object/gcobject.rs 65.60% <0.00%> (-7.64%) ⬇️
boa/src/builtins/object/mod.rs 64.00% <0.00%> (-0.87%) ⬇️
boa/src/builtins/json/mod.rs 82.05% <0.00%> (-0.85%) ⬇️
boa/src/object/mod.rs 46.45% <0.00%> (-0.54%) ⬇️
boa/src/value/display.rs 88.50% <0.00%> (-0.14%) ⬇️
boa/src/context.rs 61.64% <0.00%> (+0.55%) ⬆️
boa/src/value/mod.rs 74.58% <0.00%> (+0.80%) ⬆️
boa/src/builtins/regexp/mod.rs 70.96% <0.00%> (+0.96%) ⬆️
boa/src/object/internal_methods.rs 57.97% <0.00%> (+2.06%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1628a...6972974. Read the comment docs.

@HalidOdat HalidOdat added A-Bug Something isn't working A-Execution Issues or PRs related to code execution labels Oct 17, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 17, 2020
Copy link
Copy Markdown
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! check my comment :)

Comment thread boa/src/value/operations.rs Outdated
@HalidOdat
Copy link
Copy Markdown
Member

Looks good to me! :)

Copy link
Copy Markdown
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Razican Razican merged commit 580c7f1 into boa-dev:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Bug Something isn't working A-Execution Issues or PRs related to code execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic on division by zero

3 participants