Skip to content

update tagbot and version#27

Merged
berquist merged 1 commit into
mainfrom
dev/tagbot_update
Aug 11, 2023
Merged

update tagbot and version#27
berquist merged 1 commit into
mainfrom
dev/tagbot_update

Conversation

@rngil
Copy link
Copy Markdown
Collaborator

@rngil rngil commented Aug 10, 2023

Updating tagbot configuration.
It should not work yet - for it to work one needs to deploy SSH keys as per here.
Doing that requires access I don't have. Therefore, will register this version manually.

@JuliaRegistrator
Copy link
Copy Markdown

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

@cclib cclib deleted a comment from JuliaRegistrator Aug 10, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (278b5d9) 100.00% compared to head (1197cf7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           86        86           
=========================================
  Hits            86        86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

token: ${{ secrets.GITHUB_TOKEN }}
# Edit the following line to reflect the actual name of the GitHub Secret containing your private key
ssh: ${{ secrets.DOCUMENTER_KEY }}
# ssh: ${{ secrets.NAME_OF_MY_SSH_PRIVATE_KEY_SECRET }} No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work with DOCUMENTER_KEY?

Copy link
Copy Markdown
Collaborator Author

@rngil rngil Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just need to create the ssh key and the repo secret and make the with block look like this

with:
  token: ${{ secrets.GITHUB_TOKEN }}
  ssh: ${{ secrets.SSH_KEY }}

This is how atomsbase does it .

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivupa Can you do this since you did similar for cclib docs? I don't think I can access the SSH key.

Copy link
Copy Markdown
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix the SSH key in a follow-up.

@berquist berquist merged commit 284fbc0 into main Aug 11, 2023
@berquist berquist deleted the dev/tagbot_update branch August 11, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants