fix: remove extra space in error message causing misalignment with help text#756
Open
majiayu000 wants to merge 1 commit into
Open
fix: remove extra space in error message causing misalignment with help text#756majiayu000 wants to merge 1 commit into
majiayu000 wants to merge 1 commit into
Conversation
…lp text
The ErrorMessage SetString had a leading space (" *") that caused
the validation error to be offset from the help text in the group
footer. ErrorIndicator keeps its space as an intentional separator.
Fixes charmbracelet#723
Signed-off-by: majiayu000 <1835304752@qq.com>
Dezertgypsy
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #723
ErrorMessageinThemeBase()at theme.go:114 hadSetString(" *")with a leading space, whileHelpMessageusesSetString("*")without one. This caused the error footer to render 1 character to the right of the help text.Changed
SetString(" *")toSetString("*")so both messages start at the same column.ErrorIndicatoron line 113 keeps its leading space since that's the separator between the field title and the asterisk.The
Blurredtheme copies fromFocused(line 128), and all other themes only override the foreground color onErrorMessage, so this single change fixes it everywhere.