Skip to content

fix: screenshots for sessions #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: screenshots for sessions #4748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ed055c
fix: screenshots for sessions
kobenguyent Jan 17, 2025
6ec87b2
fix: screenshots for sessions
kobenguyent Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/helper/WebDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1788,14 +1788,14 @@ class WebDriver extends Helper {

if (browser) {
this.debug(`Screenshot of ${sessionName} session has been saved to ${outputFile}`)
return browser.saveScreenshot(outputFile)
await browser.saveScreenshot(outputFile)
}
}
}

if (!fullPage) {
this.debug(`Screenshot has been saved to ${outputFile}`)
return this.browser.saveScreenshot(outputFile)
await this.browser.saveScreenshot(outputFile)
}

const originalWindowSize = await this.browser.getWindowSize()
Expand Down
Loading