Skip to content

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Sep 11, 2025

Fixes #7480

@benz0li benz0li requested a review from a team as a code owner September 11, 2025 17:59
@benz0li
Copy link
Contributor Author

benz0li commented Sep 11, 2025

The local build succeeds, but npm run test:integration fails with

> code-server@0.0.0 test:integration
> ./ci/dev/test-integration.sh

Set CODE_SERVER_PATH to test another build of code-server
Running tests with code-server binary: 'release-standalone/bin/code-server'
 PASS  test/integration/help.test.ts
 FAIL  test/integration/installExtension.test.ts
  ● --install-extension › should use EXTENSIONS_GALLERY when set

    expect(received).rejects.toThrow(expected)

    Expected substring: "No extension gallery service configured"
    Received message:   "Command failed: release-standalone/bin/code-server --extensions-dir /tmp/code-server/tests/installExtension/installExtension-TcooxM --install-extension author.extension
    [2025-09-11T16:04:34.845Z] [
      ReferenceError: __dirname is not defined
          at Module.EV (file:///home/benz0li/projects/coder/code-server/release-standalone/lib/vscode/out/server-main.js:231:141)
          at /home/benz0li/projects/coder/code-server/release-standalone/out/node/main.js:84:40
          at Generator.next (<anonymous>)
          at fulfilled (/home/benz0li/projects/coder/code-server/release-standalone/out/node/main.js:38:58) {
        [stack]: [Getter/Setter],
        [message]: '__dirname is not defined'
      },
      [length]: 1
    ]error Got error from Code
    "

          at Module.EV (file:/home/benz0li/projects/coder/code-server/release-standalone/lib/vscode/out/server-main.js:231:141)
          at /home/benz0li/projects/coder/code-server/release-standalone/out/node/main.js:84:40
          at fulfilled (release-standalone/out/node/main.js:38:58) {
              [stack]: [Getter/Setter],
              [message]: '__dirname is not defined'
            },
            [length]: 1
          ]error Got error from Code

      18 |         EXTENSIONS_GALLERY: "{}",
      19 |       }),
    > 20 |     ).rejects.toThrow("No extension gallery service configured")
         |               ^
      21 |   })
      22 | })
      23 |

      at Object.toThrow (test/node_modules/expect/build/index.js:285:22)
      at test/integration/installExtension.test.ts:20:15
      at test/integration/installExtension.test.ts:8:71
      at Object.<anonymous>.__awaiter (test/integration/installExtension.test.ts:4:12)
      at Object.<anonymous> (test/integration/installExtension.test.ts:14:59)

Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 failed, 1 passed, 2 total
Snapshots:   0 total
Time:        2.876 s, estimated 4 s
Ran all test suites.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 11, 2025

code-server-4.104.0-rc.1-linux-amd64.tar.gz with Code 1.104.0 is deployed at https://coder.jupyter.b-data.ch.

Opening code-server results in a HTTP 500 __dirname is not defined.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 11, 2025

@code-asher IMHO this fails due to some change in lib/vscode/src/server-main.ts regarding startup.

The SHA-256 in lib/vscode/src/vs/workbench/contrib/webview/browser/pre/index.html changed, too.
ℹ️ I was unable to update, because I could not startup code-server.

@code-asher
Copy link
Member

I pushed a fix that hopefully works for __dirname 🤞

@benz0li
Copy link
Contributor Author

benz0li commented Sep 12, 2025

A new version of code-server-4.104.0-rc.1-linux-amd64.tar.gz with Code 1.104.0 is deployed at https://coder.jupyter.b-data.ch.

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • web view

Workspaces and Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2025.8.0
  • ms-python.python@2025.14.0

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@code-asher code-asher merged commit ba774d9 into coder:main Sep 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Code to 1.104
2 participants