refactor(ChangelogFormat): refactor get_metadata_from_file for better… #1596
+27
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
commented
Sep 12, 2025
| unreleased = self.parse_title_level(line) | ||
| lines = file.readlines() | ||
| for index, line in enumerate(line.strip().lower() for line in lines): | ||
| parsed_unreleased_level = self.parse_title_level(line) |
There was a problem hiding this comment.
I think we can assume that self.parse_title_level is always a pure function? Then we don't have to call it twice here.
bearomorphism
commented
Sep 12, 2025
| break # there's no need for more info | ||
| if meta.unreleased_start is not None and meta.unreleased_end is None: | ||
| meta.unreleased_end = index |
There was a problem hiding this comment.
This index is unbounded if the file is empty, although this never happens for all code paths
2bdf3cf to
54e4288
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
+ Coverage 97.33% 98.25% +0.91%
==========================================
Files 42 58 +16
Lines 2104 2692 +588
==========================================
+ Hits 2048 2645 +597
+ Misses 56 47 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… readability and better type
54e4288 to
edf22a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… readability and better type
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context