Skip to content

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Sep 13, 2025 β€’

…e behavior of library

Description

  • Move the test cases next to the test suites
  • Remove tests testing the library's behavior

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@@ -136,76 +121,3 @@ def test_semver_scheme_property():

def test_semver_implement_version_protocol():
assert isinstance(SemVer2("0.0.1"), VersionProtocol)


def test_semver_sortable():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we need to test this. The __lt__ operator is defined in packaging library and we are not overriding it.

Copy link

codecov bot commented Sep 13, 2025 β€’

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 98.25%. Comparing base (120d514) to head (8d3387c).
⚠️ Report is 805 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   97.33%   98.25%   +0.91%     
==========================================
  Files          42       58      +16     
  Lines        2104     2694     +590     
==========================================
+ Hits         2048     2647     +599     
+ Misses         56       47       -9     
Flag Coverage Ξ”
unittests 98.25% <ΓΈ> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant