Skip to content

feat: find missing files when using all:true option #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 21, 2020
Merged

feat: find missing files when using all:true option #208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65cb0c8
add example where a file should not be covered
bahmutov Apr 21, 2020
4d07ead
find files to include using globby
bahmutov Apr 21, 2020
e87a9e3
insert empty coverage for missed files
bahmutov Apr 21, 2020
e233b34
refactor a little
bahmutov Apr 21, 2020
1a3de08
change the icon for files without any statements
bahmutov Apr 21, 2020
0f76cfb
confirm file not-covered is present in the final report
bahmutov Apr 21, 2020
2f70090
search using default extension masks if include is not present
bahmutov Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
confirm file not-covered is present in the final report
  • Loading branch information
@bahmutov
bahmutov committed Apr 21, 2020
commit 0f76cfbf6923b1e12b3ea5992eb16738a70bac3a
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,11 +384,11 @@ workflows:
# we will check the final coverage report
# to make sure it only has files we are interested in
# because there are files covered at 0 in the report
# TODO confirm "not-covered.js" is at 0/0 but included in the report
command: |
../../node_modules/.bin/check-coverage main.js
../../node_modules/.bin/check-coverage second.js
# ../../node_modules/.bin/only-covered --from coverage/coverage-final.json main.js
../../node_modules/.bin/check-coverage not-covered.js
../../node_modules/.bin/only-covered --from coverage/coverage-final.json main.js second.js not-covered.js
working_directory: examples/all-files

- cypress/run:
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ For example, if you want to only include files in the `app` folder, but exclude
}
```

**Note:** if you have `all: true` NYC option set, this plugin will check the produced `.nyc_output/out.json` before generating the final report. If the `out.json` file does not have information for some files that should be there according to `include` list, then an empty placeholder will be included, see [PR 208](https://github.com/cypress-io/code-coverage/pull/208).

## Disable plugin

You can skip the client-side code coverage hooks by setting the environment variable `coverage` to `false`.
Expand Down
3 changes: 1 addition & 2 deletions examples/all-files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"report": "../../node_modules/.bin/nyc report"
},
"nyc": {
"all": true,
"include": ["*.js"]
"all": true
},
"devDependencies": {
"@babel/core": "7.9.0"
Expand Down