ignoreTestFiles is ignored when passed from cli

[Sergeon]

Current behavior:

When invoking cypress with config ignoreTestFiles=*blob from the command line, specs that match the blob aren't ignored. For instance, this npm command:

"cypress:run": "cypress run --config ignoreTestFiles=*.demo.js"

Will make a spec.demo.js to run, when it should be ignored.

Desired behavior:

Files that match the ignoreTestFiles parameter should be ignored.

Steps to reproduce:

I set up a test-tiny-repo clone with a demo of the issue. The branch is called ignore-test-files-cli-issue. You can find the repo here.

The readme has all the instructions.

Versions:

Mac Os: 10.13.4
Cypress: 2.1

[ValerieThoma]

Thank you for taking the time to provide this excellent example.
I was able to reproduce what you described.
Passing ignoreTestFiles as a CLI argument does not work as the documentation suggests: cypress-io/cypress-documentation#535
We believe this is a bug.

[brian-mann]

You need to quote ignoreTestFiles.

"cypress:run": "cypress run --config ignoreTestFiles='*.demo.js'"

Whenever you use a bare glob from the command line, by default the terminal will attempt to expand it and it will not work.

Also, I don't believe your glob is right anyway. It should likely be **/*.demo.js since it will be passed the absolute path.

[Sergeon]

Hi @brian-mann, thank you for your suggestion.

However, both

"cypress:run": "cypress run --config ignoreTestFiles='*.demo.js'"

And:

"cypress:run": "cypress run --config ignoreTestFiles='**/*.demo.js'"

Still run the demo spec. I updated the demonstration repo with the new npm commands.

[felixkempf]

This issue unfortunately still exists in cypress 3.2.0

Also I found it rather confusing that even when successfully configuring ignoreTestFiles via config file and running cypress:open, the configured ignoreTestFiles are not shown under "Settings > Configuration".

[jennifer-shehane]

I think this PR may fix this issue #3880 Can anyone verify?

[brianmcgue]

#3880 does seem to fix this issue for me.