Cypress update instructions given say to update with npm, even if you're using yarn

[silbinarywolf]

Current behavior:

When I open Cypress and there's a new update, the update instructions tell me to use npm install --save-dev cypress@3.1.2 rather than saying yarn add --dev cypress@3.1.2.

Desired behavior:

If a yarn.lock file is detected instead of a package-lock.json file, the message should given you the yarn instructions.

The location of the update code is found at:

• packages/desktop-gui/src/update/update-banner.jsx

The location of the code that tests the update banner:

• integration/update_banner_spec.coffee

Steps to reproduce:

I assume you should be able install Cypress 3.1.1, run it with ``cypress open` and see the update button / with instructions.

Versions

• 3.1.1

Operating System

Windows 10

[louise-hayes]

Could I take this issue?

[flotwig]

@louise-hayes Absolutely!

[louise-hayes]

Have reproduced error as per notes above, on MAC Sierra 10.12.6

[louise-hayes]

Hi!
I have added code to check for yarn.lock but the file check is always 'null', because the yarn.lock is not accessible to cypress during the test run phase.

Below are the screen shots, to show my progress. I attached the folders and file that cypress sees when running the tests, and also the code I have changed on my repo.

If you agree that the file yarn.lock is not accessible, as I believe, and we cannot check for it in the way I am trying:
Would it be a good idea / possible to change the code in another location, during the build, to set a flag/marker which would check and show if the yarn file exists - So that this yarn file is accesible.

I am happy to do stick with this and find a solution if you think it is the right way. If anyone has any ideas how I can make this marker flag or any feedback that would be great,

Thanks!

[chrisbreiding]

The desktop-gui package is similar to a web app in a browser and doesn't have access to the user's file system. For that, it utilizes the server package.

For the update check, the desktop-gui sends an updater:check message, which is received here in the server and calls into Updater.check here. One possible solution is to check for the existence of yarn.lock in Updater.check and return with an isYarn: true|false property along with the new version.

Honestly, it might be better to just show both options in the dialog instead of trying to determine if the user is using yarn:

To update Cypress:

1. Quit this app

2. If using npm, run `npm install --save-dev cypress@3.1.5`
   
   If using yarn, run `yarn add cypress@3.1.5`

3. Run ...

[louise-hayes]

Thanks I will implement option B, add a second message for yarn and then push that to repo for now.