cy.visit() and URL encoding

[Doogiemuc]

Current behavior:

Cypress does not support URL encoding at all. Ok I know this is the responsible of the HTTP 'client', but it would be nice if the cy.visit() function would support URL encoding in a similar way as any other JS REST client does.

Just for clarification: I am talking about URL parameters. Not HTTP headers. And also not POST body.

Desired behavior:

cy.visit() should have a parameter params of type object. The passed values in this object will be URL encoded and then all attributes are sent as parameters in the request URL.

Steps to reproduce: (app code and test code)

This code should work:

    cy.visit('/search, { params: { searchQuery: "some example string with spaces" }}
    // => GET /search?searchQuery=some%20example%20string%20with%20spaces
   
    cy.visit({
      method: 'GET',
      url: '/fetch
      params: {
        foo: 'bar'
      }
    }
    // =>GET /fetch?foo=bar

Versions

all cypress versions. Yes ok, this is a feature request.

[Doogiemuc]

Of course there is a workaround: Encode your URLs yourself with encodeURI() like we do since 1995 :-) Just kidding. The "params" parameter is pretty common. And there are also many use cases, where passing a (dynamically generated) object as params is necessary. For example one might want to pass some test fixture data here.

[flotwig]

We can pass through the qs parameter which is already supported by the request library. Opened a PR: #5040