fix: cy.then shows wrong type when collection of HTMLElement's is provided

[badeball]

User facing changelog

cy.then will show correct type when collection of HTMLElement's is provided.

Additional details

• Why was this change necessary? => When a collection of HTMLElement's is return from the previous cy.then, it is automatically wrapped with JQuery, but this behavior was not reflected in the function type.
• What is affected by this change? => N/A
• Any implementation details to explain? => Added new definition for the function.

Related issues / PRs:

#8440
#14875
#15624

How has the user experience changed?

N/A

PR Tasks

• Have tests been added/updated?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[CLAassistant]

All committers have signed the CLA.

[jennifer-shehane]

@sainthkh Any thoughts on needing this extra layer of types for .then?

[bahmutov]

@badeball can you please review our code of conduct here https://github.com/cypress-io/cypress/blob/develop/CODE_OF_CONDUCT.md

[bahmutov]

Dear @badeball if you don't think we (and I personally) eat our own food (which is the right expression, not the offensive version you used several times) by writing a lot of Cypress code, then (pun intended) I don't know what to say. Perhaps taking a break and approaching this problem after a cooling-off period would help you see this problem from our point of view.

[sainthkh]

LGTM.

When cy.then() returns an array of HTMLElements, it wraps it with JQuery. I checked it with the code below:

it('t', () => {
  cy.get('div')
  .then(($div) => {
    $div // $ExpectType JQuery<HTMLDivElement>

    return [$div[0], $div[0]]
  })
  .then(($div) => {
    console.log($div) // => jQuery object.
    $div // $ExpectType JQuery<HTMLDivElement>
  })
})

[cypress-bot]

Released in 7.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.2.0, please open a new issue.