fix: make error on integration folder point to e2e#20853
Merged
elevatebart merged 30 commits intoApr 15, 2022
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lmiller1990
approved these changes
Apr 13, 2022
Contributor
lmiller1990
left a comment
There was a problem hiding this comment.
Nice, and great PR description. Would it be a lot of complexity to add something similar for integrationFolder, like "integrationFolder is now part of specPattern"?
Member
|
I approved the updated percy snapshot. The other failing snapshots are flake. |
Contributor
Author
|
@jennifer-shehane do you need to also approve the PR ? |
ryanthemanuel
approved these changes
Apr 14, 2022
added 6 commits
April 14, 2022 11:21
tgriesser
added a commit
that referenced
this pull request
Apr 20, 2022
…e-config * 10.0-release: fix: make error on integration folder point to e2e (#20853) fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084) chore: fix windows node_modules install step (#21098) fix: webpack integration tests for app w webpack-dev-server-fresh (#21093) fix: move non spec files on migration (#21054) Bumping electron version in root chore(deps): Bumping electron dependency to 15.5.1 (#21072) fix: resolves correctly specPattern (#21057) feat: replace reconfigure button on settings page with link to config doc (#21077) feat(launchpad): update CT setup and config scaffolding (#20893) fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042) chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081) fix(cli): show additional mitigation steps for max path length error (#21047) fix: Plugin error when sending on disconnected IPC channel (#21011) chore: add internal types for cy.session command (#21028) chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
The config errors now contain the exact testing type user should place the specPattern and excludeSpecPattern in
How has the user experience changed?
given the following set of mistakes
Invalid option used at the root of the object
Invalid option used in a testing type
Invalid option used in the setupNodeEvents function
Before
User would always see this error and had to figure out where the error was and what to do about it.
After
More context is provided with the errors thrown.
Root
TestingType
setupNodeEvents
PR Tasks