fix(unify): Remove 'Reconfigure' dropdown from Testing Type chooser

[davidmunechika]

• Closes UNIFY-1533

User facing changelog

Remove the ‘Reconfigure’ dropdown from testing type chooser.
Update: this also removes the 'Choose a Browser' dropdown from testing type chooser since the functionality of this doesn't work as intended.

Additional details

Previous version:

Updated version:

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
• [n/a] Have API changes been updated in the type definitions?
• [n/a] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

4343 • 0 • 48 • 0 • 2

---

Run details

Project	cypress
Status	Passed
Commit	9af6fdc
Started	Apr 18, 2022 5:19 PM
Ended	Apr 18, 2022 5:33 PM
Duration	13:49 💡
OS	Linux Debian - 10.10
Browser	Electron 94

View run in Cypress Dashboard ➡️

---

Flakiness

	files.cy.js		1
1	... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding
	net_stubbing.cy.ts		1
1	network stubbing > intercepting request > can delay and throttle a StaticResponse

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

@davidmunechika It looks like this percy screenshot is still showing a dropdown arrow on the E2E side. https://percy.io/cypress-io/cypress/builds/17329531/changed/972768022?browser=chrome&browser_ids=23&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=800&widths=800%2C1000

[ryanthemanuel]

This is maybe out of scope for this change, but I was playing around with the state of things now and the drop down we get when we're selecting a testing type from the app is a little weird.

If you click the drop down you get an option to select 'Choose a Browser'

However, if you click that, it doesn't take you to the "Choose a Browser" screen, it launches the testing type you selected with the same browser.

[davidmunechika]

@ryanthemanuel Hmm... should I just remove the dropdown altogether?

[lmiller1990]

I think we can greatly simplify this, now we do not have a list, but a single item (effectively a boolean... if (!props.isRunning) { /* thing */ }.

[davidmunechika]

@lachlan Don't we still want the dropdown to be controllable by the MenuButton though? So I think we need to keep the MenuItem. We don't necessarily want to show the MenuItems if !props.isRunning (or similarly if menuItems.length > 0), we just want to show the dropdown button which can expand the MenuItems. So I'm not sure we can just do a boolean here...

[ZachJW34]

@davidmunechika I can't find the mocks in Figma for this dropdown, and seeing that it doesn't work as intended I say we remove it from the TestingTypeSwitcher. Would be good to sync with @ryanjwilke, but for this PR we can remove the menu and you can create a followup issue for adding back in the Choose a Browser menu item if it's still desired.

[lmiller1990]

@davidmunechika I see you raised this internally and clarified the goal. Is this PR ready for re-review?

[davidmunechika]

@lmiller1990 Yes, sorry- was waiting for the build to finish and forgot to re-request reviewers

[ryanjwilke]

@davidmunechika We can safely remove the "Choose a browser" action and the entire menu in this PR. That should be fine. This is not something we'll need to add back in.

[ZachJW34]

@davidmunechika can you create an issue for cleaning up the backend code related to reconfigure project?

[davidmunechika]

@ZachJW34 Created one here: https://cypress-io.atlassian.net/browse/UNIFY-1593