fix(bug): indeterminate checkbox state doesn't get changed

[kshastri]

• Closes Indeterminate checkbox state doesn't get changed via uncheck({ force: true }) #19098

User facing changelog

.check() or .uncheck() will remove the indeterminate state from checkboxes, even if the action is otherwise a noop.

Additional details

using .prop(indeterminate, false) here because as per the removeProp documentation it can lead to unexpected results and it was indeed not working as expected while I tried to use it.

Steps to test

2 tests have been added in check_spec.js

1. removes indeterminate prop when checkbox is checked
2. removes indeterminate prop when checkbox is unchecked

How has the user experience changed?

Before

After

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[kshastri]

@chrisbreiding, @BlueWinds - I have resolved the issue. Please have a look when you have time.

[kshastri]

@jennifer-shehane : Could you please get the 6 failing checks in CircleCI checked? The e2e test executed fine in my local for the test cases, I had added. Not sure why these 6 checks are failing.

[BlueWinds]

So interesting note: cy.uncheck() on an indeterminate checkbox doesn't emit a click event.

At first I thought this was a bug, but the more I think about it, the more it seems like the correct behavior. Users can't uncheck indeterminate checkboxes - clicking on them checks them, which was a case that already worked as expected.

Indeterminate checkboxes are already checked or unchecked, and removing indeterminate on what would otherwise be a no-op is purely a developer QOL feature. There's no browser behavior to emulate, so not emitting any events seems correct.

[BlueWinds]

@kshastri - Looks good to me. We're going to hold off merging this until after the 10.0.1 release tomorrow, but should get it in by end of week for 10.0.1.

[kshastri]

@kshastri - Looks good to me. We're going to hold off merging this until after the 10.0.1 release tomorrow, but should get it in by end of week for 10.0.1.

This is good to know. Thank you @BlueWinds

[cypress-bot]

Released in 10.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.1, please open a new issue.