fix: avoid timer size changing as it counts up#22846
Merged
Merged
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
ryanthemanuel
approved these changes
Jul 19, 2022
Contributor
|
approved by design ✅ (they love it!) TIL about |
mapsandapps
approved these changes
Jul 19, 2022
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A - very minor style tweak
Additional details
Adds
font-variant-numermic: tabular numsto stop the timer shifting around depending on the different character widths of each number. Makes non-fixed-width numbers behave like fixed-width. This is the tiniest thing but it catches my eye every now and then and bugs me.Steps to test
Run any spec and watch the timer.
How has the user experience changed?
Before:
before.mov
After:
after.mov
PR Tasks
cypress-documentation?type definitions?