fix: recollect session data after validation is successful

[emilyrohrbough]

User facing changelog

• Fixed an issue with the cy.session command where it now recollects the session data after validation is successful to correctly store the full browser context before the command ends.

Before

Screen.Recording.2022-12-12.at.9.43.07.AM.mov

After

Screen.Recording.2022-12-12.at.9.40.41.AM.mov

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

4762 • 0 • 336 • 0 • 8

---

Run details

Project	cypress
Status	Passed
Commit	ef09b65
Started	Dec 12, 2022 6:53 PM
Ended	Dec 12, 2022 7:08 PM
Duration	15:17 💡
OS	Linux Debian -
Browser	Electron 106

View run in Cypress Dashboard ➡️

---

Flakiness

	cookie_behavior.cy.ts		4
1	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2	... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4	... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
	commands/navigation.cy.ts		1
1	cy.origin navigation > #consoleProps > .go()
This comment includes only the first 5 flaky tests. See all 8 flaky tests in the Cypress Dashboard.

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[cypress-bot]

Released in 12.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.1.0, please open a new issue.