Skip to content

feat: In-App Run Notifications#27078

Merged
warrensplayer merged 32 commits into
developfrom
feature/run-notifications-m1
Jun 28, 2023
Merged

feat: In-App Run Notifications#27078
warrensplayer merged 32 commits into
developfrom
feature/run-notifications-m1

Conversation

@lmiller1990
Copy link
Copy Markdown
Contributor

@lmiller1990 lmiller1990 commented Jun 20, 2023

Additional details

This is the feature branch for the In App Notifications Milestone 1, detailed here: https://app.clickup.com/18033298/docs/h6amj-43107/h6amj-41927

Steps to test

We will do an internal bug hunt testing this feature. Let's communicate in the dedicated initiative channel.

How has the user experience changed?

Users can now receive desktop notifications relating to their runs in Cypress Cloud. We wrote about it in the documentation.

Here's an example of how it looks:

image

PR Tasks

astone123 and others added 10 commits June 12, 2023 10:40
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
* chore: disabled states

* comment

* fix types

* fix test

* fix colors, styling, dividers, add icon

* fire confirmation notification when enabled through settings

* update style for checkbox

---------

Co-authored-by: astone123 <adams@cypress.io>
@lmiller1990 lmiller1990 changed the title feature: In App Notifications feat: In App Notifications Jun 20, 2023
lmiller1990 and others added 5 commits June 21, 2023 09:26
* chore: ensure graphql query re-executes

* simplify fix

* stablize UI

* typo

* add on link

* fix test

* remove pause

* fix bug again

* on links

* remove old code
…ions (#27096) [run ci]

Co-authored-by: astone123 <adams@cypress.io>
@lmiller1990 lmiller1990 changed the title feat: In App Notifications feature: In App Notifications Jun 21, 2023
@lmiller1990 lmiller1990 marked this pull request as ready for review June 22, 2023 00:19
@lmiller1990 lmiller1990 changed the title feature: In App Notifications feat: In App Notifications Jun 22, 2023
@cypress
Copy link
Copy Markdown

cypress Bot commented Jun 22, 2023

30 flaky tests on run #48329 ↗︎

0 27917 1349 0 Flakiness 30

Details:

Merge branch 'develop' into feature/run-notifications-m1
Project: cypress Commit: 8c8cd1a183
Status: Passed Duration: 25:39 💡
Started: Jun 28, 2023 1:19 PM Ended: Jun 28, 2023 1:45 PM
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > displays each run with correct information Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video
Flakiness  scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite Output Screenshots Video
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output

The first 5 flaky specs are shown, see all 19 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

lmiller1990 and others added 7 commits June 22, 2023 11:49
* chore: show correct cloud project title in notifications

* experimental graphql refactor

* revert changeg

* fixing tests

* add cloud project actions abstraction

* refactor

* update prop

* types
* chore: capture telemetry for notifications

* recordEvent with correct source when visiting debug page

* record require events

* simplify types

* add tests

* fixing tests

* Refactor to trigger events from single place

* Fix debug e2e test

* documentation for new redirect route

* Fixing versions data source

* adding and fixing tests

* Revert merge conflict change

* Fixing ts linting

---------

Co-authored-by: Stokes Player <stokes.player@gmail.com>
Co-authored-by: Stokes Player <stokes@cypress.io>
@astone123 astone123 requested a review from a team June 23, 2023 16:57
@astone123 astone123 changed the title feat: In App Notifications feat: In-App Run Notifications Jun 23, 2023
@lmiller1990
Copy link
Copy Markdown
Contributor Author

I've tested this on all three operating systems - it looks good to me. ✅

@warrensplayer warrensplayer requested a review from a team June 27, 2023 19:56
Copy link
Copy Markdown
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@astone123 astone123 requested a review from a team June 27, 2023 20:10
@warrensplayer warrensplayer merged commit 0107efb into develop Jun 28, 2023
@warrensplayer warrensplayer deleted the feature/run-notifications-m1 branch June 28, 2023 14:23
@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Jul 6, 2023

Released in 12.17.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.0, please open a new issue.

@cypress-bot cypress-bot Bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In-App Run Notifications - M1

3 participants