fix: electron crashing prematurely when window closes prematurely while browser launch process is ongoing#27167
Merged
Merged
Conversation
e0ef3b6 to
22f8970
Compare
Passing run #48408 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
AtofStryker
commented
Jun 29, 2023
| - Fixed an issue where chrome was not recovering from browser crashes properly. Fixes [#24650](https://github.com/cypress-io/cypress/issues/24650). | ||
| - Fixed a race condition that was causing a GraphQL error to appear on the [Debug page](https://docs.cypress.io/guides/cloud/runs#Debug) when viewing a running Cypress Cloud build. Fixed in [#27134](https://github.com/cypress-io/cypress/pull/27134). | ||
| - Fixed a race condition in electron where the test window exiting prematurely during the browser launch process was causing the whole test run to fail. Addressed in [#27167](https://github.com/cypress-io/cypress/pull/27167). | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Suggested change
cacieprins
approved these changes
Jun 29, 2023
ryanthemanuel
approved these changes
Jun 29, 2023
Collaborator
ryanthemanuel
left a comment
There was a problem hiding this comment.
Nice work. Thanks for getting this one figured out!
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Fixes an issue where electron is crashing the server process when the window is closed mid launch process, which seems to always happen when video is
false. My guess is the additional process time with video set totruegives the window time to close after the launch process occurs, which is a non issue. This is only exposed when video isfalse, which is very common on therelease/13.0.0branch and is causing severe flakeSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?